Skip to content

opencl: support sinks in soft_max (attn sinks) #15152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

opencl: support sinks in soft_max (attn sinks) #15152

merged 1 commit into from
Aug 8, 2025

Conversation

lhez
Copy link
Collaborator

@lhez lhez commented Aug 7, 2025

This PR adds sinks support to soft_max as introduced in #15091.

@lhez lhez requested a review from max-krasnyansky August 7, 2025 14:06
@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend labels Aug 7, 2025
@lhez lhez marked this pull request as ready for review August 7, 2025 14:46
max-krasnyansky
max-krasnyansky approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@max-krasnyansky max-krasnyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I will test with GPT-OSS tomorrow (my setup is down today) and we can iterate if needed.

@max-krasnyansky max-krasnyansky merged commit aaa3d07 into ggml-org:master Aug 8, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@max-krasnyansky max-krasnyansky max-krasnyansky approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhez @max-krasnyansky