HIP: enable mfma mmq on gfx908 and gfx90a for select datatypes and shapes#14949
Merged
IMbackK merged 2 commits intoggml-org:masterfrom Jul 30, 2025
Merged
HIP: enable mfma mmq on gfx908 and gfx90a for select datatypes and shapes#14949IMbackK merged 2 commits intoggml-org:masterfrom
IMbackK merged 2 commits intoggml-org:masterfrom
Conversation
deepsek
reviewed
Jul 29, 2025
deepsek
reviewed
Jul 29, 2025
Collaborator
Author
|
side note: i think it might also be worth trying stream-k on GCN |
JohannesGaessler
approved these changes
Jul 30, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Aug 7, 2025
…s and shapes (ggml-org#14949)" This reverts commit ad4a700.
This was referenced Dec 29, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the MFMA path graciously provided by @deepsek on CDNA1/gfx908 and CDNA2/gfx90a devices where this is more performant than the current blas path.
This PR is fairly careful and only enables the path on datatype and batch sizes where tested to be more performant. It is likely that other data types would also benefit, and i will follow up with more at a later time.
Measurements
All mesurents on gfx908, pp1024
Performance change:
MFMA forced for all datatypes and batch sizes: