Skip to content

llama : clarify comment about pp and tg graphs [no ci] #14895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

llama : clarify comment about pp and tg graphs [no ci] #14895

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf2e89
llama : clarify comment about pp and tg graphs [no ci]
danbev Jul 27, 2025
6e0285c
squash! llama : clarify comment about pp and tg graphs [no ci]
danbev Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/llama-context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ llama_context::llama_context(

cross.v_embd.clear();

// reserve pp graph first so that buffers are only allocated once
// reserve pp (prefill prompt) graph first so that buffers are only allocated once
{
auto * gf = graph_reserve(n_tokens, n_seqs, n_tokens, mctx.get());
if (!gf) {
Expand All @@ -309,7 +309,7 @@ llama_context::llama_context(
n_nodes_pp = ggml_graph_n_nodes(gf);
}

// reserve with tg graph to get the number of splits and nodes
// reserve with tg (token generation) graph to get the number of splits and nodes
{
auto * gf = graph_reserve(n_seqs, n_seqs, n_seqs, mctx.get());
if (!gf) {
Expand Down