llama : revert gptneox cont removal #14573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The problem seems to be specific to SYCL and CUDA, could be that this is a backend bug that only happens to trigger on this model? |
Collaborator
|
@CISC I did work on some of the nc support in SYCL but it is definitely not complete. Is it because of that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mystified as to why, but GPTNeoX got broken:
https://github.com/ggml-org/ci/blob/results/llama.cpp/12/f55c302b35cfe900b84c5fe67c262026af9c44/ggml-4-x86-cuda-v100/stdall#L12992