llama-bench: fixed size of fields to correctly map to values#13183
Merged
JohannesGaessler merged 1 commit intoggml-org:masterfrom Apr 29, 2025
Merged
llama-bench: fixed size of fields to correctly map to values#13183JohannesGaessler merged 1 commit intoggml-org:masterfrom
JohannesGaessler merged 1 commit intoggml-org:masterfrom
Conversation
JohannesGaessler
approved these changes
Apr 29, 2025
Contributor
JohannesGaessler
left a comment
JohannesGaessler
left a comment
There was a problem hiding this comment.
Sorry, I didn't spot it.
Contributor
|
Thanks for fixing it. Sorry for the bad merge error |
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13096 Introduced some changes to llama-bench that have been causing segfaults to the users due to an incorrect definition of the test fields (see #13169)
I don't have expertise here so if this it not the cause of the issue or there is a better way to do it, happy to get some feedback.
Pinging @JohannesGaessler and @slaren , since they reviewed the original PR. (@thevishalagarwal for visibility as well)