Skip to content

gguf: fix division by zero in tensor dimension validation #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ashutosh0x wants to merge 1 commit into from
Closed

gguf: fix division by zero in tensor dimension validation #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/gguf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,10 @@ static struct gguf_context * gguf_init_from_reader(const struct gguf_reader & gr
ok = ok && gr.read(info.t.ne[j]);
}

// check that all ne are non-negative
if (info.t.ne[j] < 0) {
GGML_LOG_ERROR("%s: tensor '%s' dimension %" PRIu32 " has invalid number of elements: %" PRIi64 " < 0\n",
// check that all ne are positive (ne == 0 causes division by zero
// in the overflow check below: INT64_MAX/ne[1], INT64_MAX/ne[2], etc.)
if (info.t.ne[j] <= 0) {
GGML_LOG_ERROR("%s: tensor '%s' dimension %" PRIu32 " has invalid number of elements: %" PRIi64 " <= 0\n",
__func__, info.t.name, j, info.t.ne[j]);
ok = false;
break;
Expand Down