ggml-opt: fix data corruption #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the code I'm finding small defects which (while not a problem currently) could lead to bugs depending on how the API is used. I think it would make sense to accumulate the resulting small changes into a single PR to reduce the time needed for reviewing and testing. I'll convert this to a draft for now. |
JohannesGaessler
force-pushed
the
ggml-opt-fixup
branch
from
cb26686 to
ec51387
Compare
Comment on lines
-254
to
-255
| graph->grads[igrad_dst] = new_graph->grads[igrad_src]; | ||
| graph->grad_accs[igrad_dst] = new_graph->grad_accs[igrad_src]; |
There was a problem hiding this comment.
This seems to be why the tests were sometimes crashing. The direction of the copy is wrong so garbage could be written to the graph that is supposed to only be copied.
There was a problem hiding this comment.
Can confirm test-opt no longer crashes or fails.
JohannesGaessler
changed the title
slaren
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixup to #988 .
Since there is now a distinction between statically and dynamically allocated gradients some workarounds for dynamically allocated gradients can be removed. This simplifies the code a bit and reduces the possible causes for the issues in #1020 .