Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ErrUnknownBodyFormat #91

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

alecsammon
Copy link
Contributor

Use a declared error for unknown body type to allow users of the library to detect the type of error.

@alecsammon alecsammon force-pushed the unknown_body_type_error branch from 944c23a to 710cd1a Compare January 10, 2024 22:24
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d958eb) 90.77% compared to head (1b09f0b) 90.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          33       33           
  Lines        1464     1464           
=======================================
  Hits         1329     1329           
  Misses         90       90           
  Partials       45       45           
Flag Coverage Δ
unittests 90.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecsammon alecsammon force-pushed the unknown_body_type_error branch from 710cd1a to fc7174f Compare January 10, 2024 22:25
@alecsammon alecsammon force-pushed the unknown_body_type_error branch from fc7174f to 1b09f0b Compare January 10, 2024 22:25
@alecsammon alecsammon changed the title Add custom UnknownBodyTypeError Add custom ErrUnknownBodyFormat Jan 10, 2024
@alecsammon alecsammon marked this pull request as ready for review January 10, 2024 22:25
@ggicci ggicci merged commit fbcb1f2 into ggicci:main Jan 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants