Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sycl: fix example build #2570

Merged
merged 1 commit into from
Nov 18, 2024
Merged

sycl: fix example build #2570

merged 1 commit into from
Nov 18, 2024

Conversation

stsydow
Copy link
Contributor

@stsydow stsydow commented Nov 17, 2024

  • fixes linking for the ls-sycl-device binary.
  • fix warning for WHISPER_SYCL ( -> DGGML_SYCL)
  • add suggestion to link with SDL2

@@ -137,7 +137,7 @@ if (WHISPER_SDL2)
set_target_properties(lsp PROPERTIES FOLDER "examples")
if (GGML_SYCL)
add_subdirectory(sycl)
set_target_properties(sycl PROPERTIES FOLDER "examples")
set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use spaces instead of tabs:

Suggested change
set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples")
set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples")

@ggerganov ggerganov merged commit d24f981 into ggerganov:master Nov 18, 2024
40 of 44 checks passed
@stsydow stsydow deleted the fix-sycl branch November 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants