sycl: fix example build #2570
Merged
sycl: fix example build #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
reviewed
Nov 18, 2024
examples/CMakeLists.txt
Outdated
| @@ -137,7 +137,7 @@ if (WHISPER_SDL2) | |||
| set_target_properties(lsp PROPERTIES FOLDER "examples") | |||
| if (GGML_SYCL) | |||
| add_subdirectory(sycl) | |||
| set_target_properties(sycl PROPERTIES FOLDER "examples") | |||
| set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples") | |||
There was a problem hiding this comment.
Use spaces instead of tabs:
Suggested change
| set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples") | |
| set_target_properties(ls-sycl-device PROPERTIES FOLDER "examples") |
ggerganov
approved these changes
Nov 18, 2024
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Dec 5, 2024
* tag 'v1.7.2': (285 commits) release : v1.7.2 sycl: fix example build (ggerganov#2570) ci : use local ggml in Android build (ggerganov#2567) ggml : tmp workaround for whisper.cpp (skip) (ggerganov#2565) update : readme scripts : fix sync path whisper.swiftui : switch Mac dest to Mac (Designed for iPad) (ggerganov#2562) cmake : fix ppc64 check (#0) whisper : include ggml-cpu.h (#0) build : fixes talk-llama : sync llama.cpp whisper : fix build (#0) sync : ggml sycl : Fixes to broken builds and test-backend-ops (llama/10257) vulkan: Optimize contiguous copies (llama/10254) vulkan: Throttle the number of shader compiles during the build step. (llama/10222) metal : more precise Q*K in FA vec kernel (llama/10247) vulkan: Fix newly added tests for permuted mul_mat and 1D im2col (llama/10226) metal : reorder write loop in mul mat kernel + style (llama/10231) metal : fix build and some more comments (llama/10229) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ls-sycl-devicebinary.WHISPER_SYCL( ->DGGML_SYCL)