Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper : document whisper_batch.n_seq_id #1942

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

josharian
Copy link
Contributor

It is unused and has been since its introduction.

@ggerganov
Copy link
Owner

This is mostly for consistency with llama_batch from the llama.cpp project. Prefer to keep it around - it might become useful at some point if we decide to implement some advanced speculative decoding techniques

@josharian
Copy link
Contributor Author

Ack. I'll update this PR to add a few words of documentation instead.

To prevent other people from attempting to remove it, as I did.
@josharian
Copy link
Contributor Author

Ack. I'll update this PR to add a few words of documentation instead.

Updated.

Given that n_seq_id exists, seq_id probably doesn't need to be null-terminated. But I'll resist the temptation to make further gratuitous code changes. :)

@josharian josharian changed the title whisper : remove whisper_batch.n_seq_id whisper : document whisper_batch.n_seq_id Mar 10, 2024
@ggerganov ggerganov merged commit a56f435 into ggerganov:master Mar 10, 2024
47 checks passed
jiahansu pushed a commit to WiseSync/whisper.cpp that referenced this pull request Apr 17, 2024
To prevent other people from attempting to remove it, as I did.
viktor-silakov pushed a commit to viktor-silakov/whisper_node_mic.cpp that referenced this pull request May 11, 2024
To prevent other people from attempting to remove it, as I did.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
To prevent other people from attempting to remove it, as I did.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
To prevent other people from attempting to remove it, as I did.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants