CI: Provide prebuilt windows binary for hip #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
no1wudi
commented
Sep 13, 2024
no1wudi
commented
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
github-actions
bot
added
the
devops
|
To reduce the time needed for the CI to complete, can you change this so that during pull requests, only one gpu_target is built? |
OK, how about only build one target for CI and only build all targets on release? |
|
Yes that would be good, building all targets for the releases is fine, it's only not necessary for pull requests. |
no1wudi
force-pushed
the
rocm
branch
9 times, most recently
from
97621c0
to
33639e5
Compare
slaren
reviewed
Sep 20, 2024
.github/workflows/build.yml
Outdated
| cmake --build build -j ${env:NUMBER_OF_PROCESSORS} | ||
|
|
||
| windows-latest-cmake-hip-release: | ||
| if: ${{ github.event.inputs.create_release == 'true' }} |
There was a problem hiding this comment.
I think this is not going to be enough to create releases automatically on every commit to master, it also needs to check for github.event_name == 'push' && github.ref == 'refs/heads/master' like in the other jobs.
slaren
approved these changes
Sep 21, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.