Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake : do not hide GGML options + rename option #9465

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Sep 13, 2024

Using set(GGML_XXX ON) before option(GGML_XXX OFF) will hide the options from configuration tools like ccmake. To fix this, we define GGML_XXX_DEFAULT and use it in option(GGML_XXX ${GGML_XXX_DEFAULT}). This allows ggml-based projects such as llama.cpp override the default option without hiding it from the config.

Also rename GGML_CUDA_USE_GRAPHS CMake option to GGML_CUDA_GRAPHS for consistency.

@github-actions github-actions bot added the build Compilation issues label Sep 13, 2024
@ggerganov ggerganov changed the title cmake : do not hide GGML options cmake : do not hide GGML options + rename option Sep 16, 2024
@ggerganov ggerganov merged commit 19514d6 into master Sep 16, 2024
59 of 60 checks passed
@ggerganov ggerganov deleted the gg/cmake-defaults branch September 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant