cmake : use list(APPEND ...) instead of set() + dedup linker #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Green-Sky
reviewed
Sep 13, 2024
| @@ -504,7 +506,8 @@ if (GGML_HIPBLAS) | |||
| message(FATAL_ERROR "Static linking not supported for HIP/ROCm") | |||
| endif() | |||
|
|
|||
| set(GGML_EXTRA_LIBS ${GGML_EXTRA_LIBS} PUBLIC hip::host roc::rocblas roc::hipblas) | |||
| # TODO: this "PUBLIC" here seems wrong | |||
| list(APPEND GGML_EXTRA_LIBS PUBLIC hip::host roc::rocblas roc::hipblas) | |||
There was a problem hiding this comment.
I am surprised this hack works at all. But I guess its strings internally...
But that also means that everything following will be made public.
There was a problem hiding this comment.
Yup me too. I don't have HIP environment setup to test and find ways to avoid it.
|
@ggerganov , I added SYCL fix in #9469 |
* try fix sycl build * use CMAKE_CXX_FLAGS as a string variable --------- Co-authored-by: Georgi Gerganov <[email protected]>
|
And this one #9471 please. |
|
@Xarbirus Looks like we broke the Docker CI with this change: Do you have any suggestions for a fix? Will tag also the Intel team for suggestions: @abhilash1910 @airMeng @NeoZhangJianyu @luoyu-intel |
|
I have only one suggestion: #9487 ( |
4 tasks
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
…ov#9463) * cmake : use list(APPEND ...) instead of set() + dedup linker ggml-ci * cmake : try fix sycl * cmake : try to fix sycl 2 * cmake : fix sycl build (ggerganov#9469) * try fix sycl build * use CMAKE_CXX_FLAGS as a string variable --------- Co-authored-by: Georgi Gerganov <[email protected]> * one more CMAKE_CXX_FLAGS fix (ggerganov#9471) --------- Co-authored-by: Michael Podvitskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9339 (comment)
list(APPEND X Y)is considered better practice compared toset(X X Y).list(REMOVE_DUPLICATES ${GGML_EXTRA_LIBS})to deduplicate flags coming from Accelerate and Metal branches (and possibly other cases too)