-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server : add [DONE] event to /chat/completions stream response #9459
Conversation
VoidIsVoid
commented
Sep 13, 2024
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
What is the purpose of this? |
@ggerganov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could confirm that this is missing from our implementation. It's actually documented and here is an example of request having this [DONE]
message:
I tried adding this in the past but was having some issues with the test.
Currently, this test case will fail:
Failing scenarios:
features/parallel.feature:56 Multi users OAI completions compatibility -- @1.2
So you need to update the test script to be able to handle this.
Wonder if we should add this to the README.md in some place? This is breaking for many apps that use the stream raw without an OpenAI compatible client (i.e. via ReadableStream). |
IMO this is not a breaking change, because it was break before and now we just fix it. Also, /chat/completion is declared as OAI-compatible, so usage without OAI-compatible clients is not expected |