Use correct type of pooling for embedding models #5500
Merged
+94
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Feb 15, 2024
cebtenzzre
reviewed
Feb 15, 2024
cebtenzzre
approved these changes
Feb 15, 2024
|
@ggerganov Should I merge this? Don't know what the proper etiquette is around here. |
|
Yes, squash merge. I'm not at PC atm |
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
Use correct type of pooling for embedding models
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Use correct type of pooling for embedding models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously been doing sum pooling to approximate mean pooling in all cases. This changes to:
ggml_get_rowsto speed up CLS pooling (just first token)Testing with a couple of different types of models, numbers look very close to SentenceTransformers. Remaining differentials are due to the various tokenization issues discussed.