Added dynamic temperature parameters to main example cli #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Main is how many of us interact with Llama.cpp. I know it's a relatively simple change, but having it as part of the official builds will prevent us from having to build from source in order to add it after each update. The last piece of the puzzle would be server.cpp, if perhaps it could be added there as well. Glancing over the code, I think it's relatively straight-forward to add a new argument, if you wouldn't mind. Despite being in the /examples/ folder, it's frequently used. |
ggerganov
approved these changes
Feb 5, 2024
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
…ganov#5295) * added dynamic temp params in main * added help text
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
…ganov#5295) * added dynamic temp params in main * added help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.