Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add col2im kernels #808

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat : add col2im kernels #808

wants to merge 5 commits into from

Conversation

PABannier
Copy link
Contributor

This PR implements the col2im kernel to support ggml_conv_transpose_1d on Metal. It proceeds as follows:

  • Write a C kernel for col2im
  • Write a Metal kernel for col2im
  • Remove the old implementation of ggml_conv_transpose_1d
  • Implement the one using ggml_col2im

@slaren
Copy link
Collaborator

slaren commented Apr 30, 2024

When adding a new op to multiple backends, a test should be added in test-backend-ops. It should also be useful to test the implementation while working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PABannier @slaren