Skip to content

Conversation

@andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Jan 9, 2026

Several validation fixes. The only reason the dual-source blending fix is related is that both it and the frag_depth fix add fields to ShaderStageForValidation::Fragment that @ErichDonGubler added recently.

This change will conflict with #8840, which needs more discussion, so I expect #8840 will be rebased on this one. Whichever lands second should enable the entire depth_stencil_state suite.

Testing
Enables relevant CTS tests.

Squash or Rebase? Rebase

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add CHANGELOG.md entries.

* Depth bias is only supported with triangle topologies (fixes gfx-rs#6071)
* If the shader outputs `frag_depth`, the pipeline must have a depth
  attachment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dual source blending is forced if enabled (wgpu being overly strict?) Point and line primitives must not have depth bias

1 participant