Use Binder in RenderBundleEncoder.finish
#8720
Merged
+83
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleiserson
approved these changes
Dec 15, 2025
Contributor
|
I had written a comment with my review that GitHub seems to have helpfully eaten. I think my main question was, is it worth cross-referencing Otherwise, looks good, it is nice to get this cleaned up a bit. |
Member
Author
|
I added some commentary on the 2 items mentioning the long term vision of all those being deduplicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8038.
Description
Removes some duplicate code from the
RenderBundleEncoderby using theBinder(used by the other 2 pass encoders).Testing
Enabled more tests.
Squash or Rebase?
Rebase.