Move subgroup size handling in line with spec #8609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/adapter-info
branch
from
5692ec1 to
6060a05
Compare
JMS55
reviewed
Dec 1, 2025
cwfitzgerald
changed the title
| /// | ||
| /// See <https://gpuweb.github.io/gpuweb/#gpuadapterinfo> | ||
| /// where you can always use these values on all devices. | ||
| pub const MAXIMUM_SUBGROUP_MAX_SIZE: u32 = 128; |
Member
There was a problem hiding this comment.
Q: Is it possible to use more than this on some machines? If so, do we have any follow-up work for permitting larger groups?
Member
Author
There was a problem hiding this comment.
No - the max observed subgroup size in the wild is 128 on qualcomm chips (and WARP). Similarly WARP supports the same range (4 to 128) so you can test with the full range of subgroups in the wild.
ErichDonGubler
approved these changes
Dec 3, 2025
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
LGTM for merging. I have an open question, but I'm trusting this will get resolved either at or after merge.
Co-authored-by: JMS55 <[email protected]>
cwfitzgerald
force-pushed
the
cw/adapter-info
branch
from
1bfdfef to
ac504eb
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #8346
Description
Moved things over, as well as fix a few minor things in wgpu-info.
I have updated the defaults to the values specified by the WebGPU spec.
Testing
CI
Squash or Rebase?
Squash