Defer some bind group processing until draw/dispatch#8418
Merged
teoxoy merged 2 commits intogfx-rs:trunkfrom Oct 23, 2025
Merged
Defer some bind group processing until draw/dispatch#8418teoxoy merged 2 commits intogfx-rs:trunkfrom
teoxoy merged 2 commits intogfx-rs:trunkfrom
Conversation
* Don't remove resources from the usage scope, it is not necessary, and not useful, since we don't verify the scope is empty afterwards. * Avoid some unnecessary `unsafe`.
This allows us to save some work when a bind group is replaced, although WebGPU still requires us to fail a submission if any resource in any bind group that was ever referenced during encoding is destroyed. Fixes gfx-rs#8399
This was referenced Nov 11, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to save some work when a bind group is replaced, although WebGPU still requires us to fail a submission if any resource in any bind group that was ever referenced during encoding is destroyed.
Fixes #8399.
Testing
Enables some relevant CTS tests.
Squash or Rebase? Rebase (after squashing any fixups)
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.