Cause shader recompilation when changing shader constants in GLES #8291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gles by including them into cache key.
jimblandy
requested changes
Oct 8, 2025
There was a problem hiding this comment.
@Wumpf also has a question about this, but assuming that's addressed:
I understand that f64 doesn't implement hashing, but I think we should be able to do something a little better than formatting them as a string. For example, simply reinterpreting them as bytes and saving a Vec would be better.
Wumpf
changed the title
|
resolved: title was misleading, this not about push constants which shouldn't be part of shader compilation, but rather about shader constants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using GLES as a backend, shaders would not recompile when changing push constants because they were not included in the program cache key. They are now, but the way the key field is generated could be improved.
Testing
Using a simple shader choosing between two colours depending on an override constant.
Squash or Rebase?
Squash