[naga wgsl-in] Implement unary negation during const evaluation for Literal::F64 #7431
+29
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iteral::F64 This not being implemented made it impossible to express negative f64 literals. This is now fixed, and we've added a test.
cwfitzgerald
approved these changes
Mar 26, 2025
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
…iteral::F64 (gfx-rs#7431) This not being implemented made it impossible to express negative f64 literals. This is now fixed, and we've added a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This not being implemented made it impossible to express negative f64 literals. This is now fixed, and we've added a test.
Testing
Added to snapshot test
Squash or Rebase?
Doesn't matter
Checklist
cargo fmt.cargo clippy --tests. If applicable, add:cargo xtask testto run tests.