Use BufferSlice in StagingBelt::allocate().#7179
Merged
nical merged 2 commits intogfx-rs:trunkfrom Feb 20, 2025
Merged
Conversation
nical
reviewed
Feb 19, 2025
nical
approved these changes
Feb 20, 2025
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* Use `BufferSlice` in `StagingBelt::allocate()`. * Make `StagingBelt::allocate()` return just the slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Implements the plan described in review comment #6900 (comment) and was made possible by #7148.
Description
Simplifies the tuple returned by
StagingBelt::allocate()by returning aBufferSliceinstead of aBufferand offset.Testing
allocate()has no tests, but I tested that this API still works with my application.Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.Add change toCHANGELOG.md. See simple instructions inside file.StagingBeltis new this release cycle and already in the changelog.