CONTRIBUTING.md: Fill out section on pull requests.#6879
CONTRIBUTING.md: Fill out section on pull requests.#6879cwfitzgerald merged 1 commit intogfx-rs:trunkfrom
Conversation
|
I think I'm going to be able to continue reviewing this on Tuesday of this coming week. 🫡 See you then! |
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
I think this new content is good, but its relationship with other content needs some work. Let's handle the current conversations, and then see where we're at.
jimblandy
force-pushed
the
contributing-pull-requests
branch
2 times, most recently
from
23c20a2 to
788ac36
Compare
|
Hmm, the large PR language still isn't quite right. |
|
I think the wording is much better, although I'm not a WGPU maintainer (and so don't have as much experience with PRs) it seems to match with what my experience of code being reviewed feels like. |
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
Love the explanation of historical trauma and elaborating why large PRs can wrest control from maintainers in a way they can't tolerate.
Otherwise, only a couple of nits.
Approving, trusting that @jimblandy will fix up the non-non-blocking nits before merging.
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Approving with similar nit
jimblandy
force-pushed
the
contributing-pull-requests
branch
3 times, most recently
from
c74ffe2 to
cca6022
Compare
jimblandy
force-pushed
the
contributing-pull-requests
branch
from
cca6022 to
2ddebc3
Compare
|
Re-requesting review from Vecvec and Erich since I mostly rewrote the section they commented on. |
Vecvec
left a comment
Vecvec
left a comment
There was a problem hiding this comment.
I think the new version has fixed the issues I had with this. The additions to the PR template are nice.
4 participants
No description provided.