Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow non-filterable float on derived BGLs for texture binding usage w/ no sampler #6531

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 12, 2024

Connections

Description

-

Testing

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler added type: bug Something isn't working area: correctness We're behaving incorrectly labels Nov 12, 2024
@ErichDonGubler ErichDonGubler self-assigned this Nov 12, 2024
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 12, 2024 20:48
@ErichDonGubler ErichDonGubler force-pushed the nonfilt-float-for-sampled-tex-bindings-in-auto-bgl branch 2 times, most recently from fc76407 to 29dbd02 Compare November 12, 2024 22:48
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErichDonGubler ErichDonGubler force-pushed the nonfilt-float-for-sampled-tex-bindings-in-auto-bgl branch from 29dbd02 to 6b84a6f Compare November 13, 2024 12:05
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) November 13, 2024 12:05
@ErichDonGubler ErichDonGubler merged commit a2044ae into gfx-rs:trunk Nov 13, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the nonfilt-float-for-sampled-tex-bindings-in-auto-bgl branch November 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
Status: Done
2 participants