Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lower QUERY_SET_MAX_QUERYS 8192 → 4096 #6525

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: lower QUERY_SET_MAX_QUERYS 8192 → 4096 #6525

merged 1 commit into from
Nov 12, 2024
+2 −1

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 12, 2024 •
edited
Loading

Connections

Description

  • Fixes a divergence from the spec., which adjusted this limit needed to fix an issue on Metal where this is too many query sets.

Testing

Exercised in CTS by webgpu:api,validation,query_set,destroy:invalid_queryset.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 12, 2024 14:25
ErichDonGubler
ErichDonGubler commented Nov 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ErichDonGubler ErichDonGubler self-assigned this Nov 12, 2024
@ErichDonGubler ErichDonGubler added type: bug Something isn't working area: correctness We're behaving incorrectly api: metal Issues with Metal platform: macos Issues with integration with macos labels Nov 12, 2024
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) November 12, 2024 14:28
@ErichDonGubler ErichDonGubler mentioned this pull request Nov 12, 2024
Closed
1 task
@ErichDonGubler ErichDonGubler merged commit 4311091 into gfx-rs:trunk Nov 12, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the query-set-max-4096 branch November 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
api: metal Issues with Metal area: correctness We're behaving incorrectly platform: macos Issues with integration with macos type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query set creation appears to not respect platform limits
2 participants
@ErichDonGubler @teoxoy