Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naga: Fix textureNumLevels in the GLSL backend #6483

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

magcius
Copy link
Contributor

@magcius magcius commented Nov 1, 2024

... and reactivate the GLSL test for it.

Connections
Fixes #6435.

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like eyes from somebody else in @gfx-rs/wgpu before merging. I'm not familiar at all with GL.

naga/src/back/glsl/mod.rs Show resolved Hide resolved
naga/src/back/glsl/features.rs Outdated Show resolved Hide resolved
... and reactivate the GLSL test for it.

Fixes issue gfx-rs#6435.
@teoxoy
Copy link
Member

teoxoy commented Nov 4, 2024

Thanks for the fix!

@teoxoy teoxoy merged commit 9ccea81 into gfx-rs:trunk Nov 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly incorrect WGSL->GLSL transformation: textureNumLayers -> textureSize
3 participants