fix(naga-cli): allow output files with --stdin-file-path
#6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
erichdongubler/push-yoxrtozrvxzz
branch
from
1aec82d
to
caca083
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-yoxrtozrvxzz
branch
from
caca083
to
e16ebec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
--stdin-file-pathprevents writing output files #6474.Description
Change file handling in non-
bulk-validationcases to be based on an iterator, and use it to correctly treatargs.files' first entry as an input or output path in response to--stdin-file-pathbeing specified.Testing
Ran things manually with
--stdin-file-pathand without. I encourage reviewers to do their own testing, sinceChecklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.