-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WGSL: Add a skeleton for enable-extensions/enable …;
that reports nice errors
#6424
Merged
ErichDonGubler
merged 3 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:erichdongubler/push-xrkxlvzkznyw
Oct 22, 2024
Merged
WGSL: Add a skeleton for enable-extensions/enable …;
that reports nice errors
#6424
ErichDonGubler
merged 3 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:erichdongubler/push-xrkxlvzkznyw
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
type: enhancement
New feature or request
naga
Shader Translator
area: naga front-end
lang: WGSL
WebGPU Shading Language
labels
Oct 18, 2024
ErichDonGubler
force-pushed
the
erichdongubler/push-xrkxlvzkznyw
branch
3 times, most recently
from
October 18, 2024 20:28
2e61c71
to
cb8630b
Compare
ErichDonGubler
commented
Oct 18, 2024
7 tasks
ErichDonGubler
commented
Oct 18, 2024
ErichDonGubler
force-pushed
the
erichdongubler/push-xrkxlvzkznyw
branch
from
October 18, 2024 21:00
cb8630b
to
94a317f
Compare
ErichDonGubler
commented
Oct 18, 2024
ErichDonGubler
force-pushed
the
erichdongubler/push-xrkxlvzkznyw
branch
from
October 19, 2024 23:43
94a317f
to
1995464
Compare
teoxoy
requested changes
Oct 21, 2024
ErichDonGubler
changed the title
Add a skeleton for enable extensions that reports nice errors
WGSL: Add a skeleton for language extensions (i.e., Oct 22, 2024
enable …;
) that reports nice errors
ErichDonGubler
changed the title
WGSL: Add a skeleton for language extensions (i.e.,
WGSL: Add a skeleton for language extensions/Oct 22, 2024
enable …;
) that reports nice errorsenable …;
that reports nice errors
That's fine with me. |
teoxoy
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ErichDonGubler
force-pushed
the
erichdongubler/push-xrkxlvzkznyw
branch
from
October 22, 2024 20:15
5702588
to
765dacf
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-xrkxlvzkznyw
branch
from
October 22, 2024 20:18
765dacf
to
bcee0c7
Compare
7 tasks
ErichDonGubler
changed the title
WGSL: Add a skeleton for language extensions/
WGSL: Add a skeleton for enable-extensions/Oct 22, 2024
enable …;
that reports nice errorsenable …;
that reports nice errors
This was referenced Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: naga front-end
lang: WGSL
WebGPU Shading Language
naga
Shader Translator
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
enable clip_distances
extension #6236, and Converge dual-source blending with the WebGPU standard #6402.Description
This PR is much like #6352, but for the
enable
directive; it unblocks work onenable
extensions in WGSL by serving as a foundation on which to build individual extension functionality. It does the following:enable
extension list after we encounter anenable
in the directive parse path keyword, instead of emitting an unimplemented directive error.enum
modeling all known extensions, including standard-but-unimplemented ones.Note that this PR does not actually implement any extensions yet—see also the
UnimplementedEnableExtension::tracking_issue_num
method added in this PR for references to follow-up work for those.Testing
enable
directive parsing #6444.Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.