Use ManuallyDrop in remaining places
#6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
use-ManuallyDrop-in-remaining-places
branch
from
4d0adc6
to
4c52dea
Compare
ErichDonGubler
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
My understanding of the benefit of these changes is that we continue to guarantee that Drop is the sole context that should have access to these resources when run, but we now no longer have to navigate an unnecessary Optional layer to get at resource value links that should always be present over the lifetime of these resources anyway. We make every other interaction now more ergonomic.
If the above sounds right, we're on the same page; shippit!
We can rely on the snatching mechanism to take the surface texture.
teoxoy
force-pushed
the
use-ManuallyDrop-in-remaining-places
branch
from
4c52dea
to
0180aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.