Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement override-expression evaluation #5249

Merged
merged 15 commits into from
Mar 13, 2024
Merged

Implement override-expression evaluation #5249

merged 15 commits into from
Mar 13, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 14, 2024

Mainly implements override-expression evaluation for initializers of override declarations.

Tracking meta issue: #4484.

@teoxoy teoxoy requested a review from a team as a code owner February 14, 2024 14:28
@teoxoy teoxoy changed the title Pipeline constants Implements override-expression evaluation for initializers of override declarations Feb 14, 2024
@teoxoy teoxoy changed the title Implements override-expression evaluation for initializers of override declarations Implement override-expression evaluation Feb 14, 2024
jimblandy
jimblandy requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing, but I found one thing that (I think?) needs to change.

naga/src/valid/mod.rs Outdated Show resolved Hide resolved
naga/src/front/wgsl/lower/mod.rs Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
@jimblandy
Copy link
Member

@teoxoy I pushed some comments - could you see if they're correct?

@teoxoy
Copy link
Member Author

teoxoy commented Mar 13, 2024

They look great, thank you!

jimblandy
jimblandy approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good, let's merge it.

@teoxoy teoxoy requested a review from a team as a code owner March 13, 2024 19:16
@jimblandy jimblandy merged commit 9cb84c6 into gfx-rs:pipeline-constants Mar 13, 2024
21 checks passed
@ErichDonGubler
Copy link
Member

FTR: CI was failing because of #5341, but that's 👌🏻 okay, already been fixed because it was merged.

@jimblandy
Copy link
Member

jimblandy commented Mar 13, 2024 •
edited
Loading

FTR: CI was failing because of #5341, but that's 👌🏻 okay, already been fixed because it was merged.

I pushed a074d82 to fix that. All checks are now green.

Also, note that I've only landed this in gfx-rs:pipeline-constants, not trunk.

@teoxoy teoxoy mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teoxoy @jimblandy @ErichDonGubler