Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga xtask] Run validation jobs in parallel, using jobserver. #4902

Merged
merged 11 commits into from
Dec 27, 2023
Merged

[naga xtask] Run validation jobs in parallel, using jobserver. #4902

merged 11 commits into from
Dec 27, 2023

Commits on Dec 25, 2023

  1. [naga xtask] Move validation subcommands into their own module.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    5348608 View commit details
    Browse the repository at this point in the history

  2. [naga xtask] Break validation subcommands into functions.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    25e4535 View commit details
    Browse the repository at this point in the history

  3. [naga xtask] Produce output only when an error occurs.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    d33df26 View commit details
    Browse the repository at this point in the history

  4. [naga xtask] Collect validation jobs in a Vec before running them.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    d5541e2 View commit details
    Browse the repository at this point in the history

  5. [naga xtask] Remove ack_visiting function.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    e7899c1 View commit details
    Browse the repository at this point in the history

  6. [naga xtask] Use indicatif crate to report validation progress.

    @jimblandy
    jimblandy committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    04fe2a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. [naga xtask] Run validation jobs in parallel, using jobserver.

    @jimblandy
    jimblandy committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    cd6262d View commit details
    Browse the repository at this point in the history

  2. [naga xtask] Add validate all subcommand.

    @jimblandy
    jimblandy committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    517cde9 View commit details
    Browse the repository at this point in the history

  3. [naga xtask] Use log::error in preference to eprintln.

    @jimblandy
    jimblandy committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    4ab26d2 View commit details
    Browse the repository at this point in the history

  4. [naga xtask] Use anyhow::ensure! where appropriate.

    @jimblandy
    jimblandy committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b22b565 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. [naga xtask] Add and use ValidateSubcommand::all. 

    Add an `all` method to `ValidateSubcommand`, so that we can just use
matches elsewhere, and let the compile catch missing or duplicated
cases for us.
    @ErichDonGubler @jimblandy
    ErichDonGubler authored and jimblandy committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    efb563e View commit details
    Browse the repository at this point in the history