Naga(msl): Clear named expressions after writing each function #4594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
This bug started in gfx-rs/naga#2309
Found in linebender/vello#398
Description
When writing the local variables for a shader, the existance of previous functions could cause expressions to be incorrectly treated as if they were named.
This change appears to match other backends, and fixes the case where expressions which were named in earlier functions are used in local variable declarations
Testing
I made a reproducing wgsl file:
This used to have the problem, but doesn't after this PR. Additionally, we
will validatehave validated that Vello works as expected(once someone with a Mac can check).I'm not sure that a regression test is very useful here.