Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make power_preference_from_env() respect WGPU_POWER_PREF=none #4076

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Make power_preference_from_env() respect WGPU_POWER_PREF=none #4076

merged 1 commit into from
Aug 18, 2023

Conversation

fornwall
Copy link
Contributor

Also update wgpu/README.md now that default() is None.

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
Respecting WGPU_POWER_PREF=none makes no difference to wgpu testing and examples, as the fallback is already default() (which is PowerPreference::None), but makes a difference to other projects which for instance uses the logic "check for WGPU_POWER_PREF in the env, otherwise use high power".

Also updates wgpu/README.md to reflect that the default is now None.

Testing
Manually testing.

Also update wgpu/README.md now that default() is None.
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teoxoy teoxoy merged commit bf324fb into gfx-rs:trunk Aug 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants