Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Callback Ordering #4036

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix Callback Ordering #4036

merged 2 commits into from
Aug 14, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Closes #4024

Description

We immediately invoked queue.on_submitted_work_done callbacks if there were no active submissions, but that goes against the spec.

Testing

Included regression test.

@cwfitzgerald cwfitzgerald requested review from teoxoy and ErichDonGubler and removed request for teoxoy August 11, 2023 20:32
@cwfitzgerald cwfitzgerald merged commit f825ce4 into gfx-rs:trunk Aug 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

@ErichDonGubler ErichDonGubler Awaiting requested review from ErichDonGubler

@teoxoy teoxoy Awaiting requested review from teoxoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queue::on_submitted_work_done Does Not Obey WebGPU Ordering Contract
2 participants
@cwfitzgerald @nical