CI: Remove obsolete wasm-pack workaround #3728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workspace inheritance is supported by wasm-pack v0.11, so the workaround which installs a branch version isn't necessary anymore.
haraldreingruber
force-pushed
the
patch-1
branch
from
0c3acad
to
400cccc
Compare
haraldreingruber
changed the title
|
Sorry, missed this PR - superceded by #3754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
This is a follow-up of #3238
Description
Workspace inheritance is supported by wasm-pack v0.11, so the workaround added in #3238 - which installs a branch version - isn't necessary anymore. Now the released wasm-pack binary can be installed directly.
Testing
The test job would fail if wasm-pack wouldn't be correctly installed.