Gracefully handle get_next_texture failure #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! |
antonok-edm
force-pushed
the
error-reporting
branch
from
d9b3d60 to
ca4784a
Compare
Contributor
Author
|
Gotcha, same story with #368 then. Didn't realize because I've just been using the Rust API... I just updated the C API to fill an out param and return a status code - better? |
kvark
requested changes
Nov 1, 2019
Member
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
That's better, thank you for the update!
One more concern...
antonok-edm
force-pushed
the
error-reporting
branch
from
ca4784a to
b9d124c
Compare
Contributor
Author
|
@kvark How's this? |
kvark
requested changes
Nov 1, 2019
Member
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Alright, this is almost perfect. Just one more step!
antonok-edm
force-pushed
the
error-reporting
branch
from
b9d124c to
027a61a
Compare
Contributor
Author
|
@kvark ok all set :) |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
369: return Result instead of panic r=kvark a=antonok-edm Fixes gfx-rs/wgpu-rs#106 Pretty simple implementation, let me know if this isn't sufficient Co-authored-by: Anton Lazarev <[email protected]>
kvark
changed the title
Contributor
Build succeeded |
Contributor
Author
|
@kvark does it make sense to change the corresponding |
Member
|
yes, absolutely! |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Nov 6, 2019
115: Handle error case for SwapChain::get_next_texture r=kvark a=antonok-edm Updates `SwapChain::get_next_texture` to account for gfx-rs/wgpu#369. Otherwise, an invalid `Id` is returned and may cause confusing errors. Co-authored-by: Anton Lazarev <[email protected]>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
115: Handle error case for SwapChain::get_next_texture r=kvark a=antonok-edm Updates `SwapChain::get_next_texture` to account for gfx-rs#369. Otherwise, an invalid `Id` is returned and may cause confusing errors. Co-authored-by: Anton Lazarev <[email protected]>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
369: Implement SAMPLED_TEXTURE_ARRAY_NON_UNIFORM_INDEXING r=kvark a=cwfitzgerald This implements gfx-rs#715 in wgpu-rs. I haven't changed the example, as I want to actually think up a better example to use and didn't want that to block this. It will change in the future however. Co-authored-by: Connor Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gfx-rs/wgpu-rs#106
Pretty simple implementation, let me know if this isn't sufficient