-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate shader location clashes #3613
Validate shader location clashes #3613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
Could you open an issue about the unrelated test failure and include some info about your hardware/setup? |
@@ -352,6 +352,8 @@ pub enum CreateRenderPipelineError { | |||
location: wgt::ShaderLocation, | |||
offset: wgt::BufferAddress, | |||
}, | |||
#[error("Two or more attributes were assigned to the same shader lcoation {0}")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, missed a typo here (also added a few words while we're at it):
#[error("Two or more attributes were assigned to the same shader lcoation {0}")] | |
#[error("Two or more vertex attributes were assigned to the same location in the shader: {0}")] |
I'll make a PR with the typo fixes |
|
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
Validate that no two attributes are assigned to the same shader location.
(Thanks to @Wumpf for finding that quote, and for guiding me to making this PR)
Testing
cargo nextest run --no-fail-fast
works the same as onmaster
, which means one failure: