-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGl workaround for drawing single instance #3597
WebGl workaround for drawing single instance #3597
Conversation
fda5e48
to
855b4e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think we need this for both C::Draw
and C::DrawIndexed
, so we could probably remove the instance_count == 1
/draw_arrays
branch in C::Draw
entirely
@grovesNL Given that Firefox just uses Otherwise, only checking on |
That sounds good to me. I think originally we were considering these fall back paths whenever we don't have instancing support, but our minimum requirements have been raised a bit since then. |
…utes when rendering a single instance
855b4e8
to
d67ee29
Compare
Done! Much simpler now, applied the same to the v0.15 backport :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
fixes #3578
backport: #3596
Description
Whenever there is any instance attribute, we need to need use an instanced draw call on ANGLE. Otherwise, the following error will be (potentially spuriously) generated and may render incorrectly:
Testing
Tested the backport to v0.15 on https://github.com/rerun-io/rerun