Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal: if new_texture returns NULL, create_texture returns an error #3554

Merged
merged 1 commit into from
Mar 3, 2023
Merged

metal: if new_texture returns NULL, create_texture returns an error #3554

merged 1 commit into from
Mar 3, 2023

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Mar 3, 2023 •
edited by teoxoy
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
fixes #3153

Testing
Tested on M1 Mac and Intel Mac

teoxoy
teoxoy approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teoxoy teoxoy merged commit de695fc into gfx-rs:master Mar 3, 2023
@jinleili jinleili deleted the mtl branch March 3, 2023 23:40
@jesdazrez jesdazrez mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metal just returns NULL when creating a large 3D texture
2 participants
@jinleili @teoxoy