Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dxgi] fix depth16Unorm formats for nodepth and typeless #3313

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 20, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
We were using the wrong formats for depth16Unorm.
Also updated the commented stencil8 format since DXGI_FORMAT_R8_UNORM doesn't support being a "Depth/Stencil Target" but DXGI_FORMAT_D24_UNORM_S8_UINT does.

Testing

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 20, 2022
@nical nical merged commit c91cae4 into gfx-rs:master Dec 20, 2022
@teoxoy teoxoy deleted the dxgi-fix-depth16Unorm-formats branch December 20, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants