Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oops, remove gles feature from wgpu-hal's defaults #3264

Merged

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Dec 5, 2022

Totally my bad; this should not have landed. I was using it while chasing down files to change in #3044. :<

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Prompted by @jimblandy after he pointed out that I made this mistake in #3044. Sorry, everyone!

Totally my bad; this should not have landed. I was using it while
chasing down files to change in gfx-rs#3044. :<
@cwfitzgerald cwfitzgerald merged commit feddf18 into gfx-rs:master Dec 5, 2022
@ErichDonGubler ErichDonGubler deleted the revert-gles-debugging branch December 22, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants