Fix surface creation cfgs in example framework. #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3246 +/- ##
===========================================
+ Coverage 46.92% 65.40% +18.48%
===========================================
Files 82 82
Lines 39422 39451 +29
===========================================
+ Hits 18499 25804 +7305
+ Misses 20923 13647 -7276
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jimblandy
force-pushed
the
emscripten-framework-create-surface
branch
from
ebb34ab
to
c1eacaf
Compare
Expand CI coverage so that we try building `wgpu/examples/framework.rs` on
Emscripten.
The `framework.rs` library used to check:
#[cfg(not(target_arch = "wasm32"))]
to decide whether to call `instance.create_surface` or attempt to
support creating a surface from an offscreen canvas. This is not
correct: `emscripten` should be be treated as a non-web target; the
instance doesn't have a `create_surface_from_offscreen_canvas` method.
Instead, `framework.rs` should check:
#[cfg(any(not(target_arch = "wasm32"), target_os = "emscripten"))]
to treat the Emscripten target like a native target.
jimblandy
force-pushed
the
emscripten-framework-create-surface
branch
from
c1eacaf
to
6690567
Compare
cwfitzgerald
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand CI coverage so that we try building
wgpu/examples/framework.rson Emscripten.The
framework.rslibrary used to check:to decide whether to call
instance.create_surfaceor attempt to support creating a surface from an offscreen canvas. This is not correct:emscriptenshould be be treated as a non-web target; the instance doesn't have acreate_surface_from_offscreen_canvasmethod.Instead,
framework.rsshould check:to treat the Emscripten target like a native target.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.