Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Presentation Timestamp Correlation #3240

Merged
merged 17 commits into from
Dec 20, 2022

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Nov 28, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

One step of #2869.

Description

Adds a way to get the appropriate presentation timestamps and correlate it with a user timestamp.

Testing

Manually tested using example.

@cwfitzgerald cwfitzgerald changed the title Implement Presentation Timestamps Implement Presentation Timestamp Correlation Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #3240 (2870021) into master (f14bee6) will decrease coverage by 0.79%.
The diff coverage is 10.25%.

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
- Coverage   65.66%   64.86%   -0.80%     
==========================================
  Files          82       83       +1     
  Lines       39490    39607     +117     
==========================================
- Hits        25930    25692     -238     
- Misses      13560    13915     +355     
Impacted Files Coverage Δ
wgpu-core/src/instance.rs 65.10% <0.00%> (-0.92%) ⬇️
wgpu-hal/src/dx11/adapter.rs 0.00% <0.00%> (ø)
wgpu-hal/src/dx12/mod.rs 27.35% <ø> (ø)
wgpu-hal/src/empty.rs 0.00% <0.00%> (ø)
wgpu-hal/src/gles/adapter.rs 83.61% <0.00%> (-0.36%) ⬇️
wgpu-hal/src/lib.rs 26.21% <ø> (ø)
wgpu-hal/src/vulkan/adapter.rs 76.14% <0.00%> (-1.37%) ⬇️
wgpu-types/src/lib.rs 88.09% <0.00%> (-0.21%) ⬇️
wgpu/src/backend/direct.rs 56.24% <0.00%> (-0.26%) ⬇️
wgpu/src/lib.rs 51.98% <0.00%> (-0.12%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald cwfitzgerald marked this pull request as ready for review December 1, 2022 00:44
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, but it seems more complicated than necessary. See comments.

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Show resolved Hide resolved
wgpu-hal/src/metal/time.rs Outdated Show resolved Hide resolved
wgpu-hal/src/metal/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One doc fix, and one question:

wgpu-hal/src/lib.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 20, 2022 17:39
@cwfitzgerald cwfitzgerald merged commit 5241633 into gfx-rs:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants