-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Presentation Timestamp Correlation #3240
Implement Presentation Timestamp Correlation #3240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 65.66% 64.86% -0.80%
==========================================
Files 82 83 +1
Lines 39490 39607 +117
==========================================
- Hits 25930 25692 -238
- Misses 13560 13915 +355
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct, but it seems more complicated than necessary. See comments.
Co-authored-by: Jim Blandy <[email protected]>
Co-authored-by: Jim Blandy <[email protected]>
888499a
to
2870021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One doc fix, and one question:
Co-authored-by: Jim Blandy <[email protected]>
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
One step of #2869.
Description
Adds a way to get the appropriate presentation timestamps and correlate it with a user timestamp.
Testing
Manually tested using example.