-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphicsCommandList validation #3204
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
+ Coverage 65.64% 66.03% +0.39%
==========================================
Files 82 64 -18
Lines 39479 34310 -5169
==========================================
- Hits 25915 22656 -3259
+ Misses 13564 11654 -1910
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We got conflicts but g2g |
How can I help? Should I rebase onto master branch? |
Yes please. |
73bb739
to
783ff3e
Compare
Conflicts resolved. |
Thanks! |
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
We should not re-use
GraphicsCommandList
whenclose
orreset
fails.https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12graphicscommandlist-reset