deno_webgpu: Don't confuse zero with "to the end of the buffer". #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RenderBundleEncoder::set_index_buffer` and `set_vertex_buffer` interpret a `size` of `None` to mean "from the given offset to the end of the buffer", but `std::num::NonZeroU64::new` produces `None` when its argument is zero, which is quite different. Fix this similarly to the way it's handled in `op_webgpu_render_pass_set_index_buffer`. The WebGPU spec says this should work; filed as gfx-rs#3170.
jimblandy
force-pushed
the
deno-index-vertex-zero-length
branch
from
3a4b985
to
47adbe6
Compare
crowlKats
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderBundleEncoder::set_index_bufferandset_vertex_bufferinterpret asizeofNoneto mean "from the given offset to the end of the buffer", butstd::num::NonZeroU64::newproducesNonewhen its argument is zero, which is quite different. Fix this similarly to the way it's handled inop_webgpu_render_pass_set_index_buffer.The WebGPU spec says this should work; filed as #3170.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.