-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert All Default Implementations on Enums to derive(Default) #3083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just need to change the msrv in the Readme and ci to be the latest needed for #[default]
It seems that the minimum supported version is now |
Nice, not nearly as bad as I thought |
Yes, it's not so bad and it seems to have passed the test now. Should we add an entry to the changelog to say that the msvr has changed ? If so, I don't really know how and what to add, any ideas ? |
Look at last releases big announcements - I'd add a thing like that that just says what msrv we bumped to. |
Thank you ! I think it's pretty understandable as is, what do you think ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Closes #3077.
Description
Since rust-lang/rust#101040, we can now mark enums as
#[default]
, this replaces manual implementation where possible.Testing
I ran the cargo test before and after the changes and nothing changed, so I guess nothing was broken because these are very simple changes.