Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Naga b209d911 (2022-9-1). #3008

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Sep 1, 2022

This removes an expected failure on AMD RADV. I guess #2751 was our
bug all along.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy
Copy link
Member Author

Hopefully it will also sort out our CI problems.

@jimblandy
Copy link
Member Author

Okay, it looks like we missed some spots:

$ cd wgpu/examples/skybox/
$ naga shader.wgsl shader.spv
$ spirv-val --target-env vulkan1.0 shader.spv
error: line 79: [VUID-StandaloneSpirv-Flat-06202] OpEntryPoint interfaces variable must not be vertex execution model with an input storage class for Entry Point id 40.
  %gl_VertexIndex = OpVariable %_ptr_Input_uint Input

@jimblandy
Copy link
Member Author

Converted to draft since this takes Naga from a branch in my repo.

@jimblandy jimblandy force-pushed the update-naga branch 2 times, most recently from 0f436da to cad1d2d Compare September 1, 2022 23:02
@jimblandy jimblandy marked this pull request as ready for review September 2, 2022 00:04
@jimblandy jimblandy changed the title Update to Naga b63436af (2022-9-1). Update to Naga b209d911 (2022-9-1). Sep 2, 2022
wgpu-core/Cargo.toml Show resolved Hide resolved
wgpu/tests/shader_primitive_index/mod.rs Show resolved Hide resolved
This removes an expected failure on AMD RADV. I guess gfx-rs#2751 was our
bug all along.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants