Record that the buffer is mapped when its size is zero. #2877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.Description
This makes buffers behave properly when the user maps and unmaps an empty buffer range. Without this PR, 'unmap' will return an error saying that the buffer is not mapped even though the mapping closure reproted success.
It's a bit of a ridiculous test cases but fuzzers love this type of input.
The
NonNull::dangling
pointer might be intimidating, thankfully it's used in very few places so it's easy to check that we don't do dangerous things things with it. It can be summed up to the following snippet which I ran under miri without complaints of undefined behavior:Testing
No automated tests.